lkml.org 
[lkml]   [2016]   [Mar]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.13.y-ckt 079/138] cifs: fix erroneous return value
    Date
    3.13.11-ckt36 -stable review patch.  If anyone has any objections, please let me know.

    ---8<------------------------------------------------------------

    From: Anton Protopopov <a.s.protopopov@gmail.com>

    commit 4b550af519854421dfec9f7732cdddeb057134b2 upstream.

    The setup_ntlmv2_rsp() function may return positive value ENOMEM instead
    of -ENOMEM in case of kmalloc failure.

    Signed-off-by: Anton Protopopov <a.s.protopopov@gmail.com>
    Signed-off-by: Steve French <smfrench@gmail.com>
    Signed-off-by: Kamal Mostafa <kamal@canonical.com>
    ---
    fs/cifs/cifsencrypt.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/fs/cifs/cifsencrypt.c b/fs/cifs/cifsencrypt.c
    index 3299778..0bd335a 100644
    --- a/fs/cifs/cifsencrypt.c
    +++ b/fs/cifs/cifsencrypt.c
    @@ -710,7 +710,7 @@ setup_ntlmv2_rsp(struct cifs_ses *ses, const struct nls_table *nls_cp)

    ses->auth_key.response = kmalloc(baselen + tilen, GFP_KERNEL);
    if (!ses->auth_key.response) {
    - rc = ENOMEM;
    + rc = -ENOMEM;
    ses->auth_key.len = 0;
    goto setup_ntlmv2_rsp_ret;
    }
    --
    2.7.0
    \
     
     \ /
      Last update: 2016-03-10 01:01    [W:4.152 / U:0.244 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site