lkml.org 
[lkml]   [2016]   [Mar]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.13.y-ckt 113/138] hpfs: don't truncate the file when delete fails
    Date
    3.13.11-ckt36 -stable review patch.  If anyone has any objections, please let me know.

    ---8<------------------------------------------------------------

    From: Mikulas Patocka <mikulas@twibright.com>

    commit b6853f78e763d42c7a158d8de3549c9827c604ab upstream.

    The delete opration can allocate additional space on the HPFS filesystem
    due to btree split. The HPFS driver checks in advance if there is
    available space, so that it won't corrupt the btree if we run out of space
    during splitting.

    If there is not enough available space, the HPFS driver attempted to
    truncate the file, but this results in a deadlock since the commit
    7dd29d8d865efdb00c0542a5d2c87af8c52ea6c7 ("HPFS: Introduce a global mutex
    and lock it on every callback from VFS").

    This patch removes the code that tries to truncate the file and -ENOSPC is
    returned instead. If the user hits -ENOSPC on delete, he should try to
    delete other files (that are stored in a leaf btree node), so that the
    delete operation will make some space for deleting the file stored in
    non-leaf btree node.

    Reported-by: Al Viro <viro@ZenIV.linux.org.uk>
    Signed-off-by: Mikulas Patocka <mikulas@artax.karlin.mff.cuni.cz>
    Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
    Signed-off-by: Kamal Mostafa <kamal@canonical.com>
    ---
    fs/hpfs/namei.c | 31 +++----------------------------
    1 file changed, 3 insertions(+), 28 deletions(-)

    diff --git a/fs/hpfs/namei.c b/fs/hpfs/namei.c
    index 5f60bb2..12da295 100644
    --- a/fs/hpfs/namei.c
    +++ b/fs/hpfs/namei.c
    @@ -377,12 +377,11 @@ static int hpfs_unlink(struct inode *dir, struct dentry *dentry)
    struct inode *inode = dentry->d_inode;
    dnode_secno dno;
    int r;
    - int rep = 0;
    int err;

    hpfs_lock(dir->i_sb);
    hpfs_adjust_length(name, &len);
    -again:
    +
    err = -ENOENT;
    de = map_dirent(dir, hpfs_i(dir)->i_dno, name, len, &dno, &qbh);
    if (!de)
    @@ -402,33 +401,9 @@ again:
    hpfs_error(dir->i_sb, "there was error when removing dirent");
    err = -EFSERROR;
    break;
    - case 2: /* no space for deleting, try to truncate file */
    -
    + case 2: /* no space for deleting */
    err = -ENOSPC;
    - if (rep++)
    - break;
    -
    - dentry_unhash(dentry);
    - if (!d_unhashed(dentry)) {
    - hpfs_unlock(dir->i_sb);
    - return -ENOSPC;
    - }
    - if (generic_permission(inode, MAY_WRITE) ||
    - !S_ISREG(inode->i_mode) ||
    - get_write_access(inode)) {
    - d_rehash(dentry);
    - } else {
    - struct iattr newattrs;
    - /*printk("HPFS: truncating file before delete.\n");*/
    - newattrs.ia_size = 0;
    - newattrs.ia_valid = ATTR_SIZE | ATTR_CTIME;
    - err = notify_change(dentry, &newattrs, NULL);
    - put_write_access(inode);
    - if (!err)
    - goto again;
    - }
    - hpfs_unlock(dir->i_sb);
    - return -ENOSPC;
    + break;
    default:
    drop_nlink(inode);
    err = 0;
    --
    2.7.0
    \
     
     \ /
      Last update: 2016-03-10 01:01    [W:4.196 / U:0.296 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site