lkml.org 
[lkml]   [2016]   [Mar]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 01/13] hwmon: convert lm75 to use devm_thermal_zone_of_sensor_register
    Date
    This changes the driver to use the devm_ version
    of thermal_zone_of_sensor_register and cleans
    up the local points and unregister calls.

    Cc: Jean Delvare <jdelvare@suse.com>
    Cc: Guenter Roeck <linux@roeck-us.net>
    Cc: lm-sensors@lm-sensors.org
    Cc: linux-kernel@vger.kernel.org
    Signed-off-by: Eduardo Valentin <edubezval@gmail.com>
    ---
    drivers/hwmon/lm75.c | 10 +++-------
    1 file changed, 3 insertions(+), 7 deletions(-)

    diff --git a/drivers/hwmon/lm75.c b/drivers/hwmon/lm75.c
    index 0addc84..69166ab 100644
    --- a/drivers/hwmon/lm75.c
    +++ b/drivers/hwmon/lm75.c
    @@ -77,7 +77,6 @@ static const u8 LM75_REG_TEMP[3] = {
    struct lm75_data {
    struct i2c_client *client;
    struct device *hwmon_dev;
    - struct thermal_zone_device *tz;
    struct mutex update_lock;
    u8 orig_conf;
    u8 resolution; /* In bits, between 9 and 12 */
    @@ -306,11 +305,9 @@ lm75_probe(struct i2c_client *client, const struct i2c_device_id *id)
    if (IS_ERR(data->hwmon_dev))
    return PTR_ERR(data->hwmon_dev);

    - data->tz = thermal_zone_of_sensor_register(data->hwmon_dev, 0,
    - data->hwmon_dev,
    - &lm75_of_thermal_ops);
    - if (IS_ERR(data->tz))
    - data->tz = NULL;
    + devm_thermal_zone_of_sensor_register(data->hwmon_dev, 0,
    + data->hwmon_dev,
    + &lm75_of_thermal_ops);

    dev_info(dev, "%s: sensor '%s'\n",
    dev_name(data->hwmon_dev), client->name);
    @@ -322,7 +319,6 @@ static int lm75_remove(struct i2c_client *client)
    {
    struct lm75_data *data = i2c_get_clientdata(client);

    - thermal_zone_of_sensor_unregister(data->hwmon_dev, data->tz);
    hwmon_device_unregister(data->hwmon_dev);
    lm75_write_value(client, LM75_REG_CONF, data->orig_conf);
    return 0;
    --
    2.1.4
    \
     
     \ /
      Last update: 2016-03-09 23:01    [W:4.084 / U:0.092 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site