lkml.org 
[lkml]   [2016]   [Mar]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.19.y-ckt 132/196] can: ems_usb: Fix possible tx overflow
    Date
    3.19.8-ckt16 -stable review patch.  If anyone has any objections, please let me know.

    ---8<------------------------------------------------------------

    From: Gerhard Uttenthaler <uttenthaler@ems-wuensche.com>

    commit 90cfde46586d2286488d8ed636929e936c0c9ab2 upstream.

    This patch fixes the problem that more CAN messages could be sent to the
    interface as could be send on the CAN bus. This was more likely for slow baud
    rates. The sleeping _start_xmit was woken up in the _write_bulk_callback. Under
    heavy TX load this produced another bulk transfer without checking the
    free_slots variable and hence caused the overflow in the interface.

    Signed-off-by: Gerhard Uttenthaler <uttenthaler@ems-wuensche.com>
    Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
    Signed-off-by: Kamal Mostafa <kamal@canonical.com>
    ---
    drivers/net/can/usb/ems_usb.c | 14 ++++++++++----
    1 file changed, 10 insertions(+), 4 deletions(-)

    diff --git a/drivers/net/can/usb/ems_usb.c b/drivers/net/can/usb/ems_usb.c
    index 29d3f09..5c9f06c 100644
    --- a/drivers/net/can/usb/ems_usb.c
    +++ b/drivers/net/can/usb/ems_usb.c
    @@ -117,6 +117,9 @@ MODULE_LICENSE("GPL v2");
    */
    #define EMS_USB_ARM7_CLOCK 8000000

    +#define CPC_TX_QUEUE_TRIGGER_LOW 25
    +#define CPC_TX_QUEUE_TRIGGER_HIGH 35
    +
    /*
    * CAN-Message representation in a CPC_MSG. Message object type is
    * CPC_MSG_TYPE_CAN_FRAME or CPC_MSG_TYPE_RTR_FRAME or
    @@ -278,6 +281,11 @@ static void ems_usb_read_interrupt_callback(struct urb *urb)
    switch (urb->status) {
    case 0:
    dev->free_slots = dev->intr_in_buffer[1];
    + if(dev->free_slots > CPC_TX_QUEUE_TRIGGER_HIGH){
    + if (netif_queue_stopped(netdev)){
    + netif_wake_queue(netdev);
    + }
    + }
    break;

    case -ECONNRESET: /* unlink */
    @@ -528,8 +536,6 @@ static void ems_usb_write_bulk_callback(struct urb *urb)
    /* Release context */
    context->echo_index = MAX_TX_URBS;

    - if (netif_queue_stopped(netdev))
    - netif_wake_queue(netdev);
    }

    /*
    @@ -589,7 +595,7 @@ static int ems_usb_start(struct ems_usb *dev)
    int err, i;

    dev->intr_in_buffer[0] = 0;
    - dev->free_slots = 15; /* initial size */
    + dev->free_slots = 50; /* initial size */

    for (i = 0; i < MAX_RX_URBS; i++) {
    struct urb *urb = NULL;
    @@ -840,7 +846,7 @@ static netdev_tx_t ems_usb_start_xmit(struct sk_buff *skb, struct net_device *ne

    /* Slow down tx path */
    if (atomic_read(&dev->active_tx_urbs) >= MAX_TX_URBS ||
    - dev->free_slots < 5) {
    + dev->free_slots < CPC_TX_QUEUE_TRIGGER_LOW) {
    netif_stop_queue(netdev);
    }
    }
    --
    2.7.0
    \
     
     \ /
      Last update: 2016-03-09 02:41    [W:4.043 / U:0.160 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site