lkml.org 
[lkml]   [2016]   [Mar]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.19.y-ckt 157/196] af_unix: fix struct pid memory leak
    Date
    3.19.8-ckt16 -stable review patch.  If anyone has any objections, please let me know.

    ---8<------------------------------------------------------------

    From: Eric Dumazet <edumazet@google.com>

    commit fa0dc04df259ba2df3ce1920e9690c7842f8fa4b upstream.

    Dmitry reported a struct pid leak detected by a syzkaller program.

    Bug happens in unix_stream_recvmsg() when we break the loop when a
    signal is pending, without properly releasing scm.

    Fixes: b3ca9b02b007 ("net: fix multithreaded signal handling in unix recv routines")
    Reported-by: Dmitry Vyukov <dvyukov@google.com>
    Signed-off-by: Eric Dumazet <edumazet@google.com>
    Cc: Rainer Weikusat <rweikusat@mobileactivedefense.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    [ luis: backported to 3.16:
    - use siocb->scm instead of &scm ]
    Signed-off-by: Luis Henriques <luis.henriques@canonical.com>

    Signed-off-by: Kamal Mostafa <kamal@canonical.com>
    ---
    net/unix/af_unix.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/net/unix/af_unix.c b/net/unix/af_unix.c
    index 59797d8..3a27d4c 100644
    --- a/net/unix/af_unix.c
    +++ b/net/unix/af_unix.c
    @@ -2154,6 +2154,7 @@ again:

    if (signal_pending(current)) {
    err = sock_intr_errno(timeo);
    + scm_destroy(siocb->scm);
    goto out;
    }

    --
    2.7.0
    \
     
     \ /
      Last update: 2016-03-09 02:41    [W:2.168 / U:0.720 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site