lkml.org 
[lkml]   [2016]   [Mar]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.14 20/36] ALSA: hdsp: Fix wrong boolean ctl value accesses
    Date
    3.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Takashi Iwai <tiwai@suse.de>

    commit eab3c4db193f5fcccf70e884de9a922ca2c63d80 upstream.

    snd-hdsp driver accesses enum item values (int) instead of boolean
    values (long) wrongly for some ctl elements. This patch fixes them.

    Signed-off-by: Takashi Iwai <tiwai@suse.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    sound/pci/rme9652/hdsp.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    --- a/sound/pci/rme9652/hdsp.c
    +++ b/sound/pci/rme9652/hdsp.c
    @@ -2917,7 +2917,7 @@ static int snd_hdsp_get_dds_offset(struc
    {
    struct hdsp *hdsp = snd_kcontrol_chip(kcontrol);

    - ucontrol->value.enumerated.item[0] = hdsp_dds_offset(hdsp);
    + ucontrol->value.integer.value[0] = hdsp_dds_offset(hdsp);
    return 0;
    }

    @@ -2929,7 +2929,7 @@ static int snd_hdsp_put_dds_offset(struc

    if (!snd_hdsp_use_is_exclusive(hdsp))
    return -EBUSY;
    - val = ucontrol->value.enumerated.item[0];
    + val = ucontrol->value.integer.value[0];
    spin_lock_irq(&hdsp->lock);
    if (val != hdsp_dds_offset(hdsp))
    change = (hdsp_set_dds_offset(hdsp, val) == 0) ? 1 : 0;

    \
     
     \ /
      Last update: 2016-03-08 01:21    [W:4.383 / U:0.604 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site