lkml.org 
[lkml]   [2016]   [Mar]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.2.y-ckt 224/273] sctp: allow setting SCTP_SACK_IMMEDIATELY by the application
    Date
    4.2.8-ckt5 -stable review patch.  If anyone has any objections, please let me know.

    ---8<------------------------------------------------------------

    From: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>

    [ Upstream commit 27f7ed2b11d42ab6d796e96533c2076ec220affc ]

    This patch extends commit b93d6471748d ("sctp: implement the sender side
    for SACK-IMMEDIATELY extension") as it didn't white list
    SCTP_SACK_IMMEDIATELY on sctp_msghdr_parse(), causing it to be
    understood as an invalid flag and returning -EINVAL to the application.

    Note that the actual handling of the flag is already there in
    sctp_datamsg_from_user().

    https://tools.ietf.org/html/rfc7053#section-7

    Fixes: b93d6471748d ("sctp: implement the sender side for SACK-IMMEDIATELY extension")
    Signed-off-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
    Acked-by: Vlad Yasevich <vyasevich@gmail.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Kamal Mostafa <kamal@canonical.com>
    ---
    net/sctp/socket.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/net/sctp/socket.c b/net/sctp/socket.c
    index 9dee804..fb5c86b 100644
    --- a/net/sctp/socket.c
    +++ b/net/sctp/socket.c
    @@ -6641,6 +6641,7 @@ static int sctp_msghdr_parse(const struct msghdr *msg, sctp_cmsgs_t *cmsgs)

    if (cmsgs->srinfo->sinfo_flags &
    ~(SCTP_UNORDERED | SCTP_ADDR_OVER |
    + SCTP_SACK_IMMEDIATELY |
    SCTP_ABORT | SCTP_EOF))
    return -EINVAL;
    break;
    @@ -6664,6 +6665,7 @@ static int sctp_msghdr_parse(const struct msghdr *msg, sctp_cmsgs_t *cmsgs)

    if (cmsgs->sinfo->snd_flags &
    ~(SCTP_UNORDERED | SCTP_ADDR_OVER |
    + SCTP_SACK_IMMEDIATELY |
    SCTP_ABORT | SCTP_EOF))
    return -EINVAL;
    break;
    --
    2.7.0
    \
     
     \ /
      Last update: 2016-03-08 01:01    [W:2.418 / U:0.224 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site