lkml.org 
[lkml]   [2016]   [Mar]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.2.y-ckt 146/273] s390/dasd: prevent incorrect length error under z/VM after PAV changes
    Date
    4.2.8-ckt5 -stable review patch.  If anyone has any objections, please let me know.

    ---8<------------------------------------------------------------

    From: Stefan Haberland <stefan.haberland@de.ibm.com>

    commit 020bf042e5b397479c1174081b935d0ff15d1a64 upstream.

    The channel checks the specified length and the provided amount of
    data for CCWs and provides an incorrect length error if the size does
    not match. Under z/VM with simulation activated the length may get
    changed. Having the suppress length indication bit set is stated as
    good CCW coding practice and avoids errors under z/VM.

    Signed-off-by: Stefan Haberland <stefan.haberland@de.ibm.com>
    Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
    Signed-off-by: Kamal Mostafa <kamal@canonical.com>
    ---
    drivers/s390/block/dasd_alias.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/s390/block/dasd_alias.c b/drivers/s390/block/dasd_alias.c
    index ee3a6fa..47b6adb 100644
    --- a/drivers/s390/block/dasd_alias.c
    +++ b/drivers/s390/block/dasd_alias.c
    @@ -723,7 +723,7 @@ static int reset_summary_unit_check(struct alias_lcu *lcu,
    ASCEBC((char *) &cqr->magic, 4);
    ccw = cqr->cpaddr;
    ccw->cmd_code = DASD_ECKD_CCW_RSCK;
    - ccw->flags = 0 ;
    + ccw->flags = CCW_FLAG_SLI;
    ccw->count = 16;
    ccw->cda = (__u32)(addr_t) cqr->data;
    ((char *)cqr->data)[0] = reason;
    --
    2.7.0
    \
     
     \ /
      Last update: 2016-03-08 00:41    [W:4.067 / U:0.564 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site