lkml.org 
[lkml]   [2016]   [Mar]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 2/3] net: macb: Fix more coding style issues
From
Hi Joe, David,

On Mon, Mar 7, 2016 at 10:49 AM, David Miller <davem@davemloft.net> wrote:
> From: Moritz Fischer <moritz.fischer@ettus.com>
> Date: Mon, 7 Mar 2016 08:17:38 -0800
>
>> @@ -945,6 +943,7 @@ static int macb_rx_frame(struct macb *bp, unsigned int first_frag,
>> static int macb_rx(struct macb *bp, int budget)
>> {
>> int received = 0;
>> + int dropped;
>> unsigned int tail;
>> int first_frag = -1;
>>
>> @@ -968,7 +967,6 @@ static int macb_rx(struct macb *bp, int budget)
>> }
>>
>> if (ctrl & MACB_BIT(RX_EOF)) {
>> - int dropped;
>> BUG_ON(first_frag == -1);
>>
>> dropped = macb_rx_frame(bp, first_frag, tail);
>
> I totally disagree with moving local variable declarations up to the
> top-most scope.
>
> It is always best to keep them in the inner-most scope.

Alright, I can back these changes out. Didn't mean to sneak anything in.

Cheers,

Moritz

\
 
 \ /
  Last update: 2016-03-07 21:21    [W:0.054 / U:0.676 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site