lkml.org 
[lkml]   [2016]   [Mar]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH RESEND] 8021q:Add missing statements to switch case in the function, register_vlan_device
On 06.03, Nicholas Krause wrote:
> This adds the proper snprintf and break statement for formatting
> the vlan_net structure pointer, vn's name using snprintf for if
> the switch case, VLAN_NAME_TYPE_PLUS_VID occurs for this particular
> switch statement inside the function, register_vlan_device.
>
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> ---
> net/8021q/vlan.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/net/8021q/vlan.c b/net/8021q/vlan.c
> index 59555f0..91ef50e 100644
> --- a/net/8021q/vlan.c
> +++ b/net/8021q/vlan.c
> @@ -246,8 +246,11 @@ static int register_vlan_device(struct net_device *real_dev, u16 vlan_id)
> /* Put our vlan.VID in the name.
> * Name will look like: vlan0005
> */
> + snprintf(name, IFNAMSIZ, "%s%i", real_dev->name, vlan_id);
> + break;

As the comment indicates, the fall-through is intended like this.

> default:
> snprintf(name, IFNAMSIZ, "vlan%.4i", vlan_id);
> + break;
> }
>
> new_dev = alloc_netdev(sizeof(struct vlan_dev_priv), name,
> --
> 2.1.4
>

\
 
 \ /
  Last update: 2016-03-07 13:21    [W:0.091 / U:0.312 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site