lkml.org 
[lkml]   [2016]   [Mar]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.2.y-ckt 021/273] iio: light: acpi-als: Report data as processed
    Date
    4.2.8-ckt5 -stable review patch.  If anyone has any objections, please let me know.

    ---8<------------------------------------------------------------

    From: Gabriele Mazzotta <gabriele.mzt@gmail.com>

    commit fa34e6dd44d7c02c8a8468ce4a52a7506f907bef upstream.

    As per the ACPI specification (Revision 5.0) [1], the data coming
    from the sensor represent the ambient light illuminance reading
    expressed in lux. So use IIO_CHAN_INFO_PROCESSED to signify that
    the data are pre-processed.

    However, to keep backward ABI compatibility, the IIO_CHAN_INFO_RAW
    bit is not removed.

    [1] http://www.acpi.info/DOWNLOADS/ACPIspec50.pdf

    This issue has also been responsible for at least one userspace bug
    report hence marking what is a small semantic fix really for stable.
    [2] https://github.com/hadess/iio-sensor-proxy/issues/46

    Signed-off-by: Gabriele Mazzotta <gabriele.mzt@gmail.com>
    Signed-off-by: Jonathan Cameron <jic23@kernel.org>
    Signed-off-by: Kamal Mostafa <kamal@canonical.com>
    ---
    drivers/iio/light/acpi-als.c | 6 ++++--
    1 file changed, 4 insertions(+), 2 deletions(-)

    diff --git a/drivers/iio/light/acpi-als.c b/drivers/iio/light/acpi-als.c
    index 1dafa07..199f089 100644
    --- a/drivers/iio/light/acpi-als.c
    +++ b/drivers/iio/light/acpi-als.c
    @@ -54,7 +54,9 @@ static const struct iio_chan_spec acpi_als_channels[] = {
    .realbits = 32,
    .storagebits = 32,
    },
    - .info_mask_separate = BIT(IIO_CHAN_INFO_RAW),
    + /* _RAW is here for backward ABI compatibility */
    + .info_mask_separate = BIT(IIO_CHAN_INFO_RAW) |
    + BIT(IIO_CHAN_INFO_PROCESSED),
    },
    };

    @@ -152,7 +154,7 @@ static int acpi_als_read_raw(struct iio_dev *indio_dev,
    s32 temp_val;
    int ret;

    - if (mask != IIO_CHAN_INFO_RAW)
    + if ((mask != IIO_CHAN_INFO_PROCESSED) && (mask != IIO_CHAN_INFO_RAW))
    return -EINVAL;

    /* we support only illumination (_ALI) so far. */
    --
    2.7.0
    \
     
     \ /
      Last update: 2016-03-08 02:21    [W:4.028 / U:0.244 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site