lkml.org 
[lkml]   [2016]   [Mar]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.2.y-ckt 049/273] iio: inkern: fix a NULL dereference on error
    Date
    4.2.8-ckt5 -stable review patch.  If anyone has any objections, please let me know.

    ---8<------------------------------------------------------------

    From: Dan Carpenter <dan.carpenter@oracle.com>

    commit d81dac3c1c5295c61b15293074ac2bd3254e1875 upstream.

    In twl4030_bci_probe() there are some failure paths where we call
    iio_channel_release() with a NULL pointer. (Apparently, that driver can
    opperate without a valid channel pointer). Let's fix it by adding a
    NULL check in iio_channel_release().

    Fixes: 2202e1fc5a29 ('drivers: power: twl4030_charger: fix link problems when building as module')
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: Jonathan Cameron <jic23@kernel.org>
    Signed-off-by: Kamal Mostafa <kamal@canonical.com>
    ---
    drivers/iio/inkern.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/drivers/iio/inkern.c b/drivers/iio/inkern.c
    index c8bad3c..217e930 100644
    --- a/drivers/iio/inkern.c
    +++ b/drivers/iio/inkern.c
    @@ -351,6 +351,8 @@ EXPORT_SYMBOL_GPL(iio_channel_get);

    void iio_channel_release(struct iio_channel *channel)
    {
    + if (!channel)
    + return;
    iio_device_put(channel->indio_dev);
    kfree(channel);
    }
    --
    2.7.0
    \
     
     \ /
      Last update: 2016-03-08 02:21    [W:4.728 / U:0.388 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site