lkml.org 
[lkml]   [2016]   [Mar]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.2.y-ckt 113/273] crypto: atmel-sha - fix atmel_sha_remove()
    Date
    4.2.8-ckt5 -stable review patch.  If anyone has any objections, please let me know.

    ---8<------------------------------------------------------------

    From: Cyrille Pitchen <cyrille.pitchen@atmel.com>

    commit d961436c11482e974b702c8324426208f00cd7c4 upstream.

    Since atmel_sha_probe() uses devm_xxx functions to allocate resources,
    atmel_sha_remove() should no longer explicitly release them.

    Signed-off-by: Cyrille Pitchen <cyrille.pitchen@atmel.com>
    Fixes: b0e8b3417a62 ("crypto: atmel - use devm_xxx() managed function")
    Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
    Signed-off-by: Kamal Mostafa <kamal@canonical.com>
    ---
    drivers/crypto/atmel-sha.c | 7 -------
    1 file changed, 7 deletions(-)

    diff --git a/drivers/crypto/atmel-sha.c b/drivers/crypto/atmel-sha.c
    index 5b35433..e98b056 100644
    --- a/drivers/crypto/atmel-sha.c
    +++ b/drivers/crypto/atmel-sha.c
    @@ -1489,13 +1489,6 @@ static int atmel_sha_remove(struct platform_device *pdev)
    if (sha_dd->caps.has_dma)
    atmel_sha_dma_cleanup(sha_dd);

    - iounmap(sha_dd->io_base);
    -
    - clk_put(sha_dd->iclk);
    -
    - if (sha_dd->irq >= 0)
    - free_irq(sha_dd->irq, sha_dd);
    -
    return 0;
    }

    --
    2.7.0
    \
     
     \ /
      Last update: 2016-03-08 02:21    [W:4.039 / U:0.336 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site