Messages in this thread | | | Date | Sun, 6 Mar 2016 13:06:00 +0100 | From | Wolfram Sang <> | Subject | Re: [PATCHv7 0/7] Convert exiting EEPROM drivers to NVMEM |
| |
On Wed, Mar 02, 2016 at 12:56:42AM +0000, Greg KH wrote: > On Fri, Feb 26, 2016 at 08:59:17PM +0100, Andrew Lunn wrote: > > This patch set converts the old EEPROM drivers in driver/misc/eeprom to > > use the NVMEM framework. These drivers export there content in /sys as > > read only to root, since the EEPROM may contain sensitive information. > > So the first patch adds a flag so the NVMEM framework will create its > > file in /sys as root read only. > > > > To keep backwards compatibility with these older drivers, the contents > > of the EEPROM must be exports in sysfs in a file called eeprom in the > > devices node in sys, where as the NVMEM places them under class/nvmem. > > So add this optional backwards compatible to the framework, again > > using a flag. > > > > Then convert the at24, at25 and 93xx46 by adding regmap support, > > removing each drivers own /sys code and registering with the NVMEM > > framework. > > > > Lastly, the old memory accessor mechanism has been replaced with the > > nvmem equivalent. > > Nice job, all now queue up.
Yes, really. Pity I didn't have the time to review the at24-to-nvmem changes as much as I hoped for. But it will be good in the end.
I am really thankful that you made the effort to convert this hardly used memory_accessor thing and convert it into the more widely used nvmem mechanism. And clean up the unneeded bits afterwards. Always nice to see such attitude :)
Thanks,
Wolfram
[unhandled content-type:application/pgp-signature] | |