Messages in this thread | | | Date | Fri, 4 Mar 2016 18:28:23 -0800 | From | Brian Norris <> | Subject | Re: [PATCH v5 09/26] mtd: nand: omap: Clean up device tree support |
| |
Sorry, another small thing I noticed.
On Fri, Feb 19, 2016 at 11:15:31PM +0200, Roger Quadros wrote: > Move NAND specific device tree parsing to NAND driver. > > The NAND controller node must have a compatible id, register space > resource and interrupt resource. > > Signed-off-by: Roger Quadros <rogerq@ti.com> > --- [...]
> diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c > index 9e99199..0a637c4 100644 > --- a/drivers/mtd/nand/omap2.c > +++ b/drivers/mtd/nand/omap2.c > @@ -24,6 +24,7 @@ > #include <linux/slab.h> > #include <linux/of.h> > #include <linux/of_device.h> > +#include <linux/of_mtd.h> > > #include <linux/mtd/nand_bch.h> > #include <linux/platform_data/elm.h> > @@ -177,10 +178,11 @@ struct omap_nand_info { > struct gpmc_nand_regs reg; > struct gpmc_nand_ops *ops; > /* generated at runtime depending on ECC algorithm and layout selected */
^^^ I don't think that comment describes the following line. You probably meant to delete this one?
> + bool flash_bbt; > + /* generated at runtime depending on ECC algorithm and layout */ > struct nand_ecclayout oobinfo; > /* fields specific for BCHx_HW ECC scheme */ > struct device *elm_dev; > - struct device_node *of_node; > }; > > static inline struct omap_nand_info *mtd_to_omap(struct mtd_info *mtd)
[...]
Brian
| |