Messages in this thread | | | Subject | Re: [RFT PATCH 2/2] Revert "usb: dwc2: Fix probe problem on bcm2835" | From | Michael Niewoehner <> | Date | Fri, 4 Mar 2016 23:54:33 +0100 |
| |
Am 04.03.2016 um 19:23 schrieb Douglas Anderson <dianders@chromium.org>:
> This reverts commit 192cb07f7928 ("usb: dwc2: Fix probe problem on > bcm2835") now that we've found the root cause. See the change > titled ("usb: dwc2: Add a 10 ms delay to dwc2_core_reset()"). > > Signed-off-by: Douglas Anderson <dianders@chromium.org>
Tested-by: Michael Niewoehner <linux@mniewoehner.de>
> --- > drivers/usb/dwc2/core.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/usb/dwc2/core.c b/drivers/usb/dwc2/core.c > index 8710b2d3e770..7c4a6cf4c73a 100644 > --- a/drivers/usb/dwc2/core.c > +++ b/drivers/usb/dwc2/core.c > @@ -353,6 +353,12 @@ static bool dwc2_force_mode(struct dwc2_hsotg *hsotg, bool host) > set = host ? GUSBCFG_FORCEHOSTMODE : GUSBCFG_FORCEDEVMODE; > clear = host ? GUSBCFG_FORCEDEVMODE : GUSBCFG_FORCEHOSTMODE; > > + /* > + * If the force mode bit is already set, don't set it. > + */ > + if ((gusbcfg & set) && !(gusbcfg & clear)) > + return false; > + > gusbcfg &= ~clear; > gusbcfg |= set; > dwc2_writel(gusbcfg, hsotg->regs + GUSBCFG); > -- > 2.7.0.rc3.207.g0ac5344 >
| |