Messages in this thread | | | Subject | Re: [PATCH] leds: Add Chrome OS keyboard backlight LEDs driver | From | Jacek Anaszewski <> | Date | Fri, 4 Mar 2016 22:48:42 +0100 |
| |
On 03/04/2016 09:59 PM, Dmitry Torokhov wrote: > On Fri, Mar 04, 2016 at 09:55:24PM +0100, Jacek Anaszewski wrote: >> On 03/04/2016 08:13 PM, Dmitry Torokhov wrote: >>> On Fri, Mar 04, 2016 at 10:38:40AM +0100, Jacek Anaszewski wrote: >>>> Hi Evan, >>>> >>>> On 03/04/2016 09:38 AM, Evan McClain wrote: >>>>> On Thu, 2016-03-03 at 15:46 -0800, Dmitry Torokhov wrote: >>>>>> From: Simon Que <sque@chromium.org> >>>>>> >>>>>> This is a driver for ACPI-based keyboard backlight LEDs found on >>>>>> Chromebooks. The driver locates \\_SB.KBLT ACPI device and exports >>>>>> backlight as "chromeos::kbd_backlight" LED class device in sysfs. >>>>> >>>>> Was it ever decided where this driver should live? I was planning on >>>>> submitting to platform/chrome since most keyboard backlights seem to >>>>> live over there but I don't think I got a response. >>>>> >>>> >>>> It hasn't been decided yet. I can take it, but could you submit one more >>>> version, without >>>> >>>> 'owner = THIS_MODULE' in struct platform_driver keyboard_led_driver ? >>>> >>>> It is redundant, because the core will do it. >>>> >>>> Also the line with devm_kzalloc has over 80 characters. >>> >>> Also: >>> >>> - preferably use sizeof(*cdev) instead of sizeof(struct ...) >>> - do not check cdev->flags & LED_SUSPENDED in >>> keyboard_led_set_brightness() as it is not going to be called when led >>> device is suspended anyway >>> - change the MODULE_LICENSE from "GPL v2" to "GPL" as to match the >> >> I can see "either version 2 of the License" in the license notice. > >>From module.h: > > * "GPL" [GNU Public License v2 or later] > * "GPL v2" [GNU Public License v2] > > leds-chromeos-keyboard is GPL v2+ so module license should be "GPL".
That's surprising. Thanks for spotting this.
-- Best Regards, Jacek Anaszewski
| |