Messages in this thread | | | Date | Fri, 4 Mar 2016 10:32:19 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [RFC] Re: [PATCHSET 0/8] perf tools: Support multiple keys in a single hierarchy level (v1) |
| |
Em Fri, Mar 04, 2016 at 08:50:51AM +0900, Namhyung Kim escreveu: > On Thu, Mar 03, 2016 at 10:08:15AM -0300, Arnaldo Carvalho de Melo wrote: > > We should try to use tokens that already have some strong meaning > > associated to them instead of using those that are more easily > > available, otherwise our mumbo jumbo will grow even more unwieldly 8-/
> > In fact I think that in this case we could even make it look more like > > natural languages and use:
> > perf report --hierarchy -s 'prev_pid,prev_comm;next_pid,next_comm'
> > To ask for:
> > prev_pid prev_comm > > next_pid next_comm > > - 1234 bash > > 5678 firefox > > + 8912 hexchat
> > I.e. if ';' is present, it is the separator for each hierarchy level, > > with ',' being used for stating the per-hierarchy level fields.
> If it's not a common operation and we have used '{ }' for the event > groups, why not using it here too?
> $ perf report --hierarchy -s '{prev_pid,prev_comm},{next_pid,next_comm}'
> It's more verbose but more intuitive IMHO.
Right, we would be using {} consistently as a way of grouping entities.
I'm fine with that.
- Arnaldo
| |