lkml.org 
[lkml]   [2016]   [Mar]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.12 025/116] unix_diag: fix incorrect sign extension in unix_lookup_by_ino
    Date
    From: "Dmitry V. Levin" <ldv@altlinux.org>

    3.12-stable review patch. If anyone has any objections, please let me know.

    ===============

    [ Upstream commit b5f0549231ffb025337be5a625b0ff9f52b016f0 ]

    The value passed by unix_diag_get_exact to unix_lookup_by_ino has type
    __u32, but unix_lookup_by_ino's argument ino has type int, which is not
    a problem yet.
    However, when ino is compared with sock_i_ino return value of type
    unsigned long, ino is sign extended to signed long, and this results
    to incorrect comparison on 64-bit architectures for inode numbers
    greater than INT_MAX.

    This bug was found by strace test suite.

    Fixes: 5d3cae8bc39d ("unix_diag: Dumping exact socket core")
    Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
    Acked-by: Cong Wang <xiyou.wangcong@gmail.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Jiri Slaby <jslaby@suse.cz>
    ---
    net/unix/diag.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/net/unix/diag.c b/net/unix/diag.c
    index 86fa0f3b2caf..27dd3dcb7739 100644
    --- a/net/unix/diag.c
    +++ b/net/unix/diag.c
    @@ -219,7 +219,7 @@ done:
    return skb->len;
    }

    -static struct sock *unix_lookup_by_ino(int ino)
    +static struct sock *unix_lookup_by_ino(unsigned int ino)
    {
    int i;
    struct sock *sk;
    --
    2.7.2
    \
     
     \ /
      Last update: 2016-03-04 11:21    [W:4.102 / U:0.372 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site