lkml.org 
[lkml]   [2016]   [Mar]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.12 039/116] bnx2x: Don't notify about scratchpad parities
    Date
    From: Manish Chopra <Manish.Chopra@qlogic.com>

    3.12-stable review patch. If anyone has any objections, please let me know.

    ===============

    commit ad6afbe9578d1fa26680faf78c846bd8c00d1d6e upstream.

    The scratchpad is a shared block between all functions of a given device.
    Due to HW limitations, we can't properly close its parity notifications
    to all functions on legal flows.
    E.g., it's possible that while taking a register dump from one function
    a parity error would be triggered on other functions.

    Today driver doesn't consider this parity as a 'real' parity unless its
    being accompanied by additional indications [which would happen in a real
    parity scenario]; But it does print notifications for such events in the
    system logs.

    This eliminates such prints - in case of real parities driver would have
    additional indications; But if this is the only signal user will not even
    see a parity being logged in the system.

    Signed-off-by: Manish Chopra <Manish.Chopra@qlogic.com>
    Signed-off-by: Yuval Mintz <Yuval.Mintz@qlogic.com>
    Signed-off-by: Ariel Elior <Ariel.Elior@qlogic.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Patrick Schaaf <netdev@bof.de>
    Tested-by: Patrick Schaaf <netdev@bof.de>
    Signed-off-by: Jiri Slaby <jslaby@suse.cz>
    ---
    drivers/net/ethernet/broadcom/bnx2x/bnx2x.h | 11 +++++++----
    drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c | 20 ++++++++++++++------
    2 files changed, 21 insertions(+), 10 deletions(-)

    diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x.h b/drivers/net/ethernet/broadcom/bnx2x/bnx2x.h
    index 930ced0bcc8b..ce534b2bbd95 100644
    --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x.h
    +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x.h
    @@ -2371,10 +2371,13 @@ void bnx2x_igu_clear_sb_gen(struct bnx2x *bp, u8 func, u8 idu_sb_id,
    AEU_INPUTS_ATTN_BITS_IGU_PARITY_ERROR | \
    AEU_INPUTS_ATTN_BITS_MISC_PARITY_ERROR)

    -#define HW_PRTY_ASSERT_SET_3 (AEU_INPUTS_ATTN_BITS_MCP_LATCHED_ROM_PARITY | \
    - AEU_INPUTS_ATTN_BITS_MCP_LATCHED_UMP_RX_PARITY | \
    - AEU_INPUTS_ATTN_BITS_MCP_LATCHED_UMP_TX_PARITY | \
    - AEU_INPUTS_ATTN_BITS_MCP_LATCHED_SCPAD_PARITY)
    +#define HW_PRTY_ASSERT_SET_3_WITHOUT_SCPAD \
    + (AEU_INPUTS_ATTN_BITS_MCP_LATCHED_ROM_PARITY | \
    + AEU_INPUTS_ATTN_BITS_MCP_LATCHED_UMP_RX_PARITY | \
    + AEU_INPUTS_ATTN_BITS_MCP_LATCHED_UMP_TX_PARITY)
    +
    +#define HW_PRTY_ASSERT_SET_3 (HW_PRTY_ASSERT_SET_3_WITHOUT_SCPAD | \
    + AEU_INPUTS_ATTN_BITS_MCP_LATCHED_SCPAD_PARITY)

    #define HW_PRTY_ASSERT_SET_4 (AEU_INPUTS_ATTN_BITS_PGLUE_PARITY_ERROR | \
    AEU_INPUTS_ATTN_BITS_ATC_PARITY_ERROR)
    diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
    index 237a5611d3f6..1e912b16c487 100644
    --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
    +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
    @@ -4613,9 +4613,7 @@ static bool bnx2x_check_blocks_with_parity3(struct bnx2x *bp, u32 sig,
    res |= true;
    break;
    case AEU_INPUTS_ATTN_BITS_MCP_LATCHED_SCPAD_PARITY:
    - if (print)
    - _print_next_block((*par_num)++,
    - "MCP SCPAD");
    + (*par_num)++;
    /* clear latched SCPAD PATIRY from MCP */
    REG_WR(bp, MISC_REG_AEU_CLR_LATCH_SIGNAL,
    1UL << 10);
    @@ -4677,6 +4675,7 @@ static bool bnx2x_parity_attn(struct bnx2x *bp, bool *global, bool print,
    (sig[3] & HW_PRTY_ASSERT_SET_3) ||
    (sig[4] & HW_PRTY_ASSERT_SET_4)) {
    int par_num = 0;
    +
    DP(NETIF_MSG_HW, "Was parity error: HW block parity attention:\n"
    "[0]:0x%08x [1]:0x%08x [2]:0x%08x [3]:0x%08x [4]:0x%08x\n",
    sig[0] & HW_PRTY_ASSERT_SET_0,
    @@ -4684,9 +4683,18 @@ static bool bnx2x_parity_attn(struct bnx2x *bp, bool *global, bool print,
    sig[2] & HW_PRTY_ASSERT_SET_2,
    sig[3] & HW_PRTY_ASSERT_SET_3,
    sig[4] & HW_PRTY_ASSERT_SET_4);
    - if (print)
    - netdev_err(bp->dev,
    - "Parity errors detected in blocks: ");
    + if (print) {
    + if (((sig[0] & HW_PRTY_ASSERT_SET_0) ||
    + (sig[1] & HW_PRTY_ASSERT_SET_1) ||
    + (sig[2] & HW_PRTY_ASSERT_SET_2) ||
    + (sig[4] & HW_PRTY_ASSERT_SET_4)) ||
    + (sig[3] & HW_PRTY_ASSERT_SET_3_WITHOUT_SCPAD)) {
    + netdev_err(bp->dev,
    + "Parity errors detected in blocks: ");
    + } else {
    + print = false;
    + }
    + }
    res |= bnx2x_check_blocks_with_parity0(bp,
    sig[0] & HW_PRTY_ASSERT_SET_0, &par_num, print);
    res |= bnx2x_check_blocks_with_parity1(bp,
    --
    2.7.2
    \
     
     \ /
      Last update: 2016-03-04 11:21    [W:4.238 / U:0.228 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site