lkml.org 
[lkml]   [2016]   [Mar]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.12 097/116] drm/radeon: use post-decrement in error handling
    Date
    From: Rasmus Villemoes <linux@rasmusvillemoes.dk>

    3.12-stable review patch. If anyone has any objections, please let me know.

    ===============

    commit bc3f5d8c4ca01555820617eb3b6c0857e4df710d upstream.

    We need to use post-decrement to get the pci_map_page undone also for
    i==0, and to avoid some very unpleasant behaviour if pci_map_page
    failed already at i==0.

    Reviewed-by: Christian König <christian.koenig@amd.com>
    Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
    Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
    Signed-off-by: Jiri Slaby <jslaby@suse.cz>
    ---
    drivers/gpu/drm/radeon/radeon_ttm.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/radeon/radeon_ttm.c
    index 02d3c3820803..f5931e5f44fd 100644
    --- a/drivers/gpu/drm/radeon/radeon_ttm.c
    +++ b/drivers/gpu/drm/radeon/radeon_ttm.c
    @@ -621,7 +621,7 @@ static int radeon_ttm_tt_populate(struct ttm_tt *ttm)
    0, PAGE_SIZE,
    PCI_DMA_BIDIRECTIONAL);
    if (pci_dma_mapping_error(rdev->pdev, gtt->ttm.dma_address[i])) {
    - while (--i) {
    + while (i--) {
    pci_unmap_page(rdev->pdev, gtt->ttm.dma_address[i],
    PAGE_SIZE, PCI_DMA_BIDIRECTIONAL);
    gtt->ttm.dma_address[i] = 0;
    --
    2.7.2
    \
     
     \ /
      Last update: 2016-03-04 11:01    [W:4.257 / U:0.284 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site