Messages in this thread | | | Date | Thu, 31 Mar 2016 10:52:09 -0700 | Subject | Re: [PATCH v2] spi: rockchip: fix warning of static check | From | Doug Anderson <> |
| |
Shawn,
On Wed, Mar 30, 2016 at 8:11 PM, Shawn Lin <shawn.lin@rock-chips.com> wrote: > Use dma_request_chan instead of dma_request_slave_channel, > in this case we can check EPROBE_DEFER without static > warning.
Technically this is more than just a warning fix. The previous commit 61cadcf46cfd ("spi: rockchip: check requesting dma channel with EPROBE_DEFER") could never have done what it was supposed to do because dma_request_slave_channel() could never return EPROBE_DEFER. ...so really this makes the previous commit work properly.
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com> > Cc: Doug Anderson <dianders@chromium.org> > Cc: Dan Carpenter <dan.carpenter@oracle.com> > Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com> > > --- > > Changes in v2: > - use dma_request_chan and replace IS_ERR_OR_NULL() > with IS_ERR > - do the same for rx > > drivers/spi/spi-rockchip.c | 14 +++++++++----- > 1 file changed, 9 insertions(+), 5 deletions(-)
Reviewed-by: Douglas Anderson <dianders@chromium.org>
| |