lkml.org 
[lkml]   [2016]   [Mar]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RESEND v2] phy: hi6220: Add missing MFD_SYSCON dependency on HAS_IOMEM
    On Wed, 30 Mar 2016, Krzysztof Kozlowski wrote:

    > The MFD_SYSCON depends on HAS_IOMEM so when selecting it avoid unmet
    > direct dependencies.
    >
    > This fixes warning on allyesconfig on ARCH=um:
    >
    > warning: (ST_IRQCHIP && HIP04_ETH && STMMAC_PLATFORM && DWMAC_IPQ806X &&
    > DWMAC_LPC18XX && DWMAC_ROCKCHIP && DWMAC_SOCFPGA && DWMAC_STI && TI_CPSW
    > && PINCTRL_ROCKCHIP && PINCTRL_DOVE && POWER_RESET_KEYSTONE &&
    > S3C2410_WATCHDOG && VIDEO_OMAP3 && VIDEO_S5P_FIMC && USB_XHCI_MTK &&
    > RTC_DRV_AT91SAM9 && LPC18XX_DMAMUX && VIDEO_OMAP4 && HWSPINLOCK_QCOM &&
    > ATMEL_ST && QCOM_GSBI && PHY_HI6220_USB)
    > selects MFD_SYSCON which has unmet direct dependencies (HAS_IOMEM)
    >
    > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
    > Acked-by: Lee Jones <lee.jones@linaro.org>

    Holding off on this until the discussion reaches some kind of
    consensus.

    > ---
    >
    > Changes since v1:
    > 1. Remove the comment why HAS_IOMEM dependency was added.
    > 2. Exdended description.
    > ---
    > drivers/phy/Kconfig | 1 +
    > 1 file changed, 1 insertion(+)
    >
    > diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
    > index 879ac798f6f7..17e5f5c7ffff 100644
    > --- a/drivers/phy/Kconfig
    > +++ b/drivers/phy/Kconfig
    > @@ -226,6 +226,7 @@ config PHY_MT65XX_USB3
    > config PHY_HI6220_USB
    > tristate "hi6220 USB PHY support"
    > depends on (ARCH_HISI && ARM64) || COMPILE_TEST
    > + depends on HAS_IOMEM
    > select GENERIC_PHY
    > select MFD_SYSCON
    > help

    --
    Lee Jones
    Linaro STMicroelectronics Landing Team Lead
    Linaro.org │ Open source software for ARM SoCs
    Follow Linaro: Facebook | Twitter | Blog

    \
     
     \ /
      Last update: 2016-03-30 10:41    [W:3.214 / U:0.656 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site