Messages in this thread | | | Date | Wed, 30 Mar 2016 14:09:16 -0700 | From | Guenter Roeck <> | Subject | Re: [PATCH v4 1/2] watchdog: imx2_wdt: add external reset support via 'ext-reset-output' dt prop |
| |
On Wed, Mar 30, 2016 at 09:22:33AM +0800, Shawn Guo wrote: > On Mon, Mar 28, 2016 at 04:19:15PM -0400, Akshay Bhat wrote: > > Hi Shawn, > > > > On 02/28/2016 08:56 AM, Fabio Estevam wrote: > > >Rob, > > > > > >On Thu, Jan 28, 2016 at 6:28 PM, Akshay Bhat <akshay.bhat@timesys.com> wrote: > > > > > >>>I have no objections against the idea and the code itself. > > >>>But as Guenter pointed out: it would be handy to get feedback from the > > >>>devicetree maintainers on the above discussion. > > >>> > > >>>Kind regards, > > >>>Wim. > > >>> > > >> > > >>Any suggestions on whether a vendor specific prefix is necessary? > > > > > >Any comments? > > > > > > > Is this something you can help with, since you are the iMX > > architecture/devicetree maintainer? Appreciate any feedback. > > FWIW, > > Acked-by: Shawn Guo <shawnguo@kernel.org> > > Guenter, > > I think it's reasonable to pick up the patch, if we have it copied to DT > maintainers and on the list for a long period of time, and do not see > any objection from anyone. > The question was if the property name should be ext-reset-output or fsl,ext-reset-output. In my opinion, it should be fsl,ext-reset-output because it is not a generic property. Tim disagrees.
So we have two options: Change the property name to fsl,ext-reset-output, which I would accept, or wait for a devicetree maintainer to make a decision.
Guenter
| |