lkml.org 
[lkml]   [2016]   [Mar]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] regulator: Support ramp-up delay for drivers with get_voltage()
On Wed, Mar 30, 2016 at 05:23:12PM +0300, Georgi Djakov wrote:

> + } else if (_regulator_is_enabled(rdev) &&
> + rdev->desc->ops->set_voltage_time_sel &&
> + rdev->desc->ops->get_voltage) {
> + int uV = rdev->desc->ops->get_voltage(rdev);
> +
> + if (uV > 0) {
> + old_selector = regulator_map_voltage(rdev, uV, uV);
> + if (old_selector < 0)
> + return old_selector;
> + }

If a driver is using selectors it should use selectors uninformly, it
should not mix and match selector and raw voltage interfaces. If we
the set and get operations are not symmetric I'd expect we're going to
run into problems sooner rather than later.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2016-03-30 20:01    [W:0.045 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site