Messages in this thread | | | Date | Wed, 30 Mar 2016 14:41:29 +0300 | Subject | Re: [PATCH v6 2/2] gpio: dwapb: add gpio-signaled acpi event support | From | Andy Shevchenko <> |
| |
On Sat, Mar 26, 2016 at 4:31 AM, qiujiang <qiujiang@huawei.com> wrote: > This patch adds gpio-signaled acpi event support. It is used for > power button on hisilicon D02 board, an arm64 platform.
Yes, looks good, my tag stays.
> @@ -502,10 +509,17 @@ dwapb_gpio_get_pdata(struct device *dev) > } > } > > + if (has_acpi_companion(dev) && pp->idx == 0) > + pp->irq = platform_get_irq(to_platform_device(dev), 0); > +
> pp->irq_shared = false; > pp->gpio_base = -1;
> + > if (dev->of_node) > pp->name = to_of_node(fwnode)->full_name;
This change doesn't belong the patch, though it should gone with the two lines of pp->name assignment as per Alan's suggestion to get rid of pp->name completely.
> + > + if (has_acpi_companion(dev)) > + pp->name = acpi_dev_name(to_acpi_device_node(fwnode));
-- With Best Regards, Andy Shevchenko
| |