Messages in this thread | | | From | Naoya Horiguchi <> | Subject | Re: [PATCH] mm/hugetlb: use EOPNOTSUPP in hugetlb sysctl handlers | Date | Thu, 3 Mar 2016 23:05:57 +0000 |
| |
On Thu, Mar 03, 2016 at 11:02:51AM +0100, Jan Stancek wrote: > Replace ENOTSUPP with EOPNOTSUPP. If hugepages are not supported, > this value is propagated to userspace. EOPNOTSUPP is part of uapi > and is widely supported by libc libraries. > > Cc: Andrew Morton <akpm@linux-foundation.org> > Cc: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com> > Cc: Mike Kravetz <mike.kravetz@oracle.com> > Cc: Hillf Danton <hillf.zj@alibaba-inc.com> > Cc: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> > Cc: Dave Hansen <dave.hansen@linux.intel.com> > Cc: Paul Gortmaker <paul.gortmaker@windriver.com> > > Signed-off-by: Jan Stancek <jstancek@redhat.com>
Acked-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
> --- > mm/hugetlb.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > index 01f2b48c8618..851a29928a99 100644 > --- a/mm/hugetlb.c > +++ b/mm/hugetlb.c > @@ -2751,7 +2751,7 @@ static int hugetlb_sysctl_handler_common(bool obey_mempolicy, > int ret; > > if (!hugepages_supported()) > - return -ENOTSUPP; > + return -EOPNOTSUPP; > > table->data = &tmp; > table->maxlen = sizeof(unsigned long); > @@ -2792,7 +2792,7 @@ int hugetlb_overcommit_handler(struct ctl_table *table, int write, > int ret; > > if (!hugepages_supported()) > - return -ENOTSUPP; > + return -EOPNOTSUPP; > > tmp = h->nr_overcommit_huge_pages; > > -- > 1.8.3.1 >
| |