Messages in this thread | | | Subject | Re: [PATCH v4 6/8] create/adjust generated/autoksyms.h | From | Michal Marek <> | Date | Thu, 3 Mar 2016 23:14:39 +0100 |
| |
Hi Nicolas,
sorry for the late review.
Dne 29.2.2016 v 04:48 Nicolas Pitre napsal(a): > +set -e > + > +cur_ksyms_file="include/generated/autoksyms.h" > +new_ksyms_file="include/generated/autoksyms.h.tmpnew" > + > +info() { [ "$quiet" != "silent_" ] && printf " %-7s %s\n" "$1" "$2"; }
Using && as a shorthand for if-statements does not work when running in -e mode. This particular line causes the script to fail in silent mode. There other uses of && in the script are inside sub-shells, so they do work, but it would be good to convert them to avoid breakage if the script is edited later.
> +# Extract changes between old and new list and touch corresponding > +# dependency files. > +# Note: sort -m doesn't work well with underscore prefixed symbols so we > +# use 'cat ... | sort' instead. > +changed=$( > +count=0 > +cat "$cur_ksyms_file" "$new_ksyms_file" | sort | uniq -u |
sort "$cur_ksyms_file" "$new_ksyms_file" ? sort -m probably does not work, because the input files are not sorted.
Michal
| |