lkml.org 
[lkml]   [2016]   [Mar]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 03/17] dt-bindings: Add PLX Technology RPS IRQ Controller bindings
    On Thu, Mar 03, 2016 at 12:39:56PM +0100, Neil Armstrong wrote:
    > Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
    > ---
    > .../bindings/interrupt-controller/plxtech,rps-irq.txt | 17 +++++++++++++++++
    > 1 file changed, 17 insertions(+)
    > create mode 100644 Documentation/devicetree/bindings/interrupt-controller/plxtech,rps-irq.txt
    >
    > diff --git a/Documentation/devicetree/bindings/interrupt-controller/plxtech,rps-irq.txt b/Documentation/devicetree/bindings/interrupt-controller/plxtech,rps-irq.txt
    > new file mode 100644
    > index 0000000..db117a0
    > --- /dev/null
    > +++ b/Documentation/devicetree/bindings/interrupt-controller/plxtech,rps-irq.txt

    ...

    > +- compatible: Should be "plxtech,nas782x-rps"

    Hi Neil

    It would be nice to be consistent with the naming.

    Maybe also the filename of the driver itself should be changed. You
    had an interesting sorting problem in the Makefile, which a consistent
    name would help with.

    Andrew

    \
     
     \ /
      Last update: 2016-03-03 16:41    [W:4.133 / U:0.088 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site