lkml.org 
[lkml]   [2016]   [Mar]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH] perf tools: explicitly declare inc_group_count as a void function
On Thu, Mar 03, 2016 at 12:30:14PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The return type is not defined, so it defaults to int, however,
> the function is not returning anything, so this is clearly not
> correct. Make it a void function.

Acked-by: Jiri Olsa <jolsa@kernel.org>

thanks,
jirka

>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> tools/perf/util/parse-events.y | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/util/parse-events.y b/tools/perf/util/parse-events.y
> index 85c44ba..5be4a5f 100644
> --- a/tools/perf/util/parse-events.y
> +++ b/tools/perf/util/parse-events.y
> @@ -28,7 +28,7 @@ do { \
> INIT_LIST_HEAD(list); \
> } while (0)
>
> -static inc_group_count(struct list_head *list,
> +static void inc_group_count(struct list_head *list,
> struct parse_events_evlist *data)
> {
> /* Count groups only have more than 1 members */
> --
> 2.7.0
>

\
 
 \ /
  Last update: 2016-03-03 14:21    [W:0.168 / U:0.136 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site