lkml.org 
[lkml]   [2016]   [Mar]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [rtc-linux] Re: [RFC 04/15] irqchip: st: Add missing MFD_SYSCON dependency on HAS_IOMEM
    From
    2016-03-03 21:28 GMT+09:00 Arnd Bergmann <arnd@arndb.de>:
    > On Thursday 03 March 2016 21:00:57 Krzysztof Kozlowski wrote:
    >> >
    >> > Not user visible.
    >>
    >> Hmmm... you are right (here and in other patches) but why am I getting
    >> all these errors:
    >> warning: (ST_IRQCHIP && HIP04_ETH && STMMAC_PLATFORM && DWMAC_IPQ806X
    >> && DWMAC_LPC18XX && DWMAC_ROCKCHIP && DWMAC_SOCFPGA && DWMAC_STI &&
    >> TI_CPSW && PINCTRL_ROCKCHIP && PINCTRL_DOVE && POWER_RESET_KEYSTONE &&
    >> S3C2410_WATCHDOG && VIDEO_OMAP3 && VIDEO_S5P_FIMC && USB_XHCI_MTK &&
    >> RTC_DRV_AT91SAM9 && LPC18XX_DMAMUX && VIDEO_OMAP4 && HWSPINLOCK_QCOM
    >> && ATMEL_ST && QCOM_GSBI && PHY_HI6220_USB) selects MFD_SYSCON which
    >> has unmet direct dependencies (HAS_IOMEM)
    >> ?
    >> (ARCH=um, allyesconfig)
    >
    > The problem is that Kconfig will just print any option that
    > selects the one that has a missing dependency, but doesn't
    > show which of those are actually enabled.

    Indeed... but apparently putting direct HAS_IOMEM dependency on these
    symbols silences the Kconfig warning.

    >> Adding depends here (and in other places) really helps... but it
    >> should not have any impact...
    >
    > I think patch 5 by itself would have been sufficient.

    Thanks for analysis. Since all patches are independent (and IMHO the
    last one is not needed really) so I won't resend the patchset. Instead
    let maintainer pick what is meaningful.

    Best regards,
    Krzysztof

    \
     
     \ /
      Last update: 2016-03-03 14:21    [W:3.016 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site