lkml.org 
[lkml]   [2016]   [Mar]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.2 57/62] ubi: Fix out of bounds write in volume update code
    3.2.79-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Richard Weinberger <richard@nod.at>

    commit e4f6daac20332448529b11f09388f1d55ef2084c upstream.

    ubi_start_leb_change() allocates too few bytes.
    ubi_more_leb_change_data() will write up to req->upd_bytes +
    ubi->min_io_size bytes.

    Signed-off-by: Richard Weinberger <richard@nod.at>
    Reviewed-by: Boris Brezillon <boris.brezillon@free-electrons.com>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    drivers/mtd/ubi/upd.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/mtd/ubi/upd.c
    +++ b/drivers/mtd/ubi/upd.c
    @@ -197,7 +197,7 @@ int ubi_start_leb_change(struct ubi_devi
    vol->ch_lnum = req->lnum;
    vol->ch_dtype = req->dtype;

    - vol->upd_buf = vmalloc(req->bytes);
    + vol->upd_buf = vmalloc(ALIGN((int)req->bytes, ubi->min_io_size));
    if (!vol->upd_buf)
    return -ENOMEM;

    \
     
     \ /
      Last update: 2016-03-29 22:41    [W:4.395 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site