Messages in this thread | | | Subject | Re: [PATCH 3/3] staging: fwserial: (coding style) Rewriting a call to a long function | From | Dominique van den Broeck <> | Date | Tue, 29 Mar 2016 19:50:26 +0200 |
| |
> Does this really look better to you? > > Long identifiers like "wait_event_interruptible_timeout" > (32 chars) make > using 80 columns a bit silly. > > Please remember checkpatch is a stupid script and that > not every warning it emits is dicta.
Actually, not much and as a matter of fact, I hesitated before sending this particular patch. That's also why I submitted it as the last one of them all and why it fixes only a single row : so we can eventually reject it easily.
I'm not a checkpatch.pl nazi neither and anyway, even the "Development Process" document specify that it's not to be considered as a strict rule if it makes the things worse.
But I found it useful anyway because this set brings back all the warnings to only two categories (comments over spinlocks and memory barriers) and also because this kind of minor corrections could still be appreciated by people that have better things to do... :-)
Cheers.
| |