Messages in this thread | | | Date | Mon, 28 Mar 2016 11:15:44 -0700 | From | Guenter Roeck <> | Subject | Re: [PATCH 09/17] watchdog: qcom: add kpss-standalone to device tree binding |
| |
On Mon, Mar 28, 2016 at 12:02:47PM -0500, Matthew McClintock wrote: > On Mar 25, 2016, at 9:15 AM, Rob Herring <robh@kernel.org> wrote: > > > > On Wed, Mar 23, 2016 at 05:05:04PM -0500, Matthew McClintock wrote: > >> Update the compatible string to add new device tree binding > >> > >> CC: linux-watchdog@vger.kernel.org > >> Signed-off-by: Matthew McClintock <mmcclint@codeaurora.org> > >> --- > >> Documentation/devicetree/bindings/watchdog/qcom-wdt.txt | 1 + > >> 1 file changed, 1 insertion(+) > >> > >> diff --git a/Documentation/devicetree/bindings/watchdog/qcom-wdt.txt b/Documentation/devicetree/bindings/watchdog/qcom-wdt.txt > >> index 60bb2f98..45b37cf 100644 > >> --- a/Documentation/devicetree/bindings/watchdog/qcom-wdt.txt > >> +++ b/Documentation/devicetree/bindings/watchdog/qcom-wdt.txt > >> @@ -6,6 +6,7 @@ Required properties : > >> > >> "qcom,kpss-timer" > >> "qcom,scss-timer" > >> + "qcom,kpss-standalone" > > > > What SoC(s) is this in. Use SoC specific compatible strings please. > > So ipq4019 wins the race because we are the first to try to enable watchdog for this block? > > qcom,kpss-ipq4019 ? > It is a dedicated watchdog block, isn't it ? "qcom,kpss-ipq4019" would not refer to a specific block. Devicetree maintainers may have a better idea, but it seems to me that there should be 'wdt' or 'watchdog' in the property name.
Guenter
| |