lkml.org 
[lkml]   [2016]   [Mar]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 01/30] ACPICA: Linuxize: reduce divergences for 20160212 release
    From
    Date
    On Thu, 2016-03-24 at 09:38 +0800, Lv Zheng wrote:
    > The patch reduces source code differences between the Linux kernel and the
    > ACPICA upstream so that the linuxized ACPICA 20160212 release can be
    > applied with reduced human intervention.

    In the very first patch fragment:

    > diff --git a/drivers/acpi/acpica/hwregs.c b/drivers/acpi/acpica/hwregs.c
    []
    > @@ -152,7 +152,7 @@ acpi_hw_validate_register(struct acpi_generic_address *reg,
    >   *
    >   ******************************************************************************/
    >  
    > -acpi_status acpi_hw_read(u32 *value, struct acpi_generic_address *reg)
    > +acpi_status acpi_hw_read(u32 *value, struct acpi_generic_address * reg)

    The second argument * style appears the opposite of normal style
    and a different style than the first argument * style.

    > diff --git a/drivers/acpi/osl.c b/drivers/acpi/osl.c
    []
    > @@ -582,7 +582,7 @@ static char acpi_os_name[ACPI_MAX_OVERRIDE_LEN];
    >  
    >  acpi_status
    >  acpi_os_predefined_override(const struct acpi_predefined_names *init_val,
    > -     char **new_val)
    > +     acpi_string *new_val)

    And here:

    acpi_string pointer style 1:

    > diff --git a/include/acpi/acpiosxf.h b/include/acpi/acpiosxf.h
    []
    > @@ -96,7 +96,7 @@ acpi_physical_address acpi_os_get_root_pointer(void);
    >  #ifndef ACPI_USE_ALTERNATE_PROTOTYPE_acpi_os_predefined_override
    >  acpi_status
    >  acpi_os_predefined_override(const struct acpi_predefined_names *init_val,
    > -     char **new_val);
    > +     acpi_string * new_val);

    acpi_string pointer style 2:

    There are varying styles for acpi_string *

    So far, this just looks sloppy.
    Should the rest be reviewed?

    \
     
     \ /
      Last update: 2016-03-24 03:21    [W:4.343 / U:0.296 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site