lkml.org 
[lkml]   [2016]   [Mar]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: net/sctp: stack-out-of-bounds in sctp_getsockopt
From
Date
On Thu, 2016-03-24 at 00:42 +0800, Baozeng wrote:

> Thanks for your quick patch. I tested it but it still reproduce the
> bug. We should limit the length of the name,
> not the prefix. The following patch fixs it.
>
> diff --git a/net/bridge/netfilter/ebtables.c b/net/bridge/netfilter/ebtables.c
> index 67b2e27..4837425 100644
> --- a/net/bridge/netfilter/ebtables.c
> +++ b/net/bridge/netfilter/ebtables.c
> @@ -346,7 +346,7 @@ find_inlist_lock(struct list_head *head, const
> char *name, const char *prefix,
> {
> return try_then_request_module(
> find_inlist_lock_noload(head, name, error, mutex),
> - "%s%s", prefix, name);
> + "%s%.*s", prefix, EBT_TABLE_MAXNAMELEN, name);
> }
>

Right you are, please send a formal patch ?

Thanks !


\
 
 \ /
  Last update: 2016-03-23 19:01    [W:0.056 / U:0.144 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site