lkml.org 
[lkml]   [2016]   [Mar]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] tpm: drop 'base' from struct tpm_vendor_specific
On Wed, Mar 23, 2016 at 08:16:09AM +0200, Jarkko Sakkinen wrote:
> Dropped the field 'base' from struct tpm_vendor_specific and migrated
> it to the private structures of tpm_atmel and tpm_nsc.
>
> Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>

> +#define atmel_get_priv(chip) ((struct tpm_atmel_priv *) chip->vendor.priv)

This should be a static inline function not a define

> +#define tpm_nsc_get_priv(chip) ((struct tpm_nsc_priv *) chip->vendor.priv)

Ditto

Otherwise looks ok

Reviewed-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>

Jason

\
 
 \ /
  Last update: 2016-03-23 18:01    [W:0.046 / U:0.924 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site