lkml.org 
[lkml]   [2016]   [Mar]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[PATCH] sdcardfs: fix itnull.cocci warnings
Remove NULL tests, as the index variable of list_for_each_entry cannot be 
NULL.

Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
---

The code seems to have a lot of unnecessary braces as well.

tree: https://android.googlesource.com/kernel/common android-4.4
head: f06e869f936e548fd3fd78ddcbebe171f0defadb
commit: 1e2d3bbcf3f5a603e62dfa0514a43e13ee679d4f [4/6] sdcardfs: Bring up
to date with Android M permissions:

packagelist.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

--- a/fs/sdcardfs/packagelist.c
+++ b/fs/sdcardfs/packagelist.c
@@ -160,7 +160,7 @@ static int insert_str_to_int(struct pack
mutex_unlock(&pkgl_dat->hashtable_lock);

list_for_each_entry(sbinfo, &sdcardfs_super_list, list) {
- if (sbinfo) {
+ {
fixup_perms(sbinfo->sb);
}
}
@@ -189,7 +189,7 @@ static void remove_str_to_int(struct pac
}
mutex_unlock(&pkgl_dat->hashtable_lock);
list_for_each_entry(sbinfo, &sdcardfs_super_list, list) {
- if (sbinfo) {
+ {
fixup_perms(sbinfo->sb);
}
}
\
 
 \ /
  Last update: 2016-03-23 08:41    [W:0.032 / U:0.156 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site