lkml.org 
[lkml]   [2016]   [Mar]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 2/6] writeback: wb_start_writeback() should use WB_SYNC_ALL for WB_REASON_SYNC
    Date
    If you call sync, the initial call to wakeup_flusher_threads() ends up
    calling wb_start_writeback() with reason=WB_REASON_SYNC, but
    wb_start_writeback() always uses WB_SYNC_NONE as the writeback mode.
    Ensure that we use WB_SYNC_ALL for a sync operation.

    Signed-off-by: Jens Axboe <axboe@fb.com>
    ---
    fs/fs-writeback.c | 5 ++++-
    1 file changed, 4 insertions(+), 1 deletion(-)

    diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c
    index 5c46ed9f3e14..97a9e9987134 100644
    --- a/fs/fs-writeback.c
    +++ b/fs/fs-writeback.c
    @@ -936,7 +936,10 @@ void wb_start_writeback(struct bdi_writeback *wb, long nr_pages,
    return;
    }

    - work->sync_mode = WB_SYNC_NONE;
    + if (reason == WB_REASON_SYNC)
    + work->sync_mode = WB_SYNC_ALL;
    + else
    + work->sync_mode = WB_SYNC_NONE;
    work->nr_pages = nr_pages;
    work->range_cyclic = range_cyclic;
    work->reason = reason;
    --
    2.4.1.168.g1ea28e1
    \
     
     \ /
      Last update: 2016-03-22 19:21    [W:2.520 / U:0.052 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site