lkml.org 
[lkml]   [2016]   [Mar]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v6 8/8] debugfs: unproxify files created through debugfs_create_u32_array()
    Date
    The struct file_operations u32_array_fops associated with files created
    through debugfs_create_u32_array() has been lifetime aware already:
    everything needed for subsequent operation is copied to a ->f_private
    buffer at file opening time in u32_array_open(). Now, ->open() is always
    protected against file removal issues by the debugfs core.

    There is no need for the debugfs core to wrap the u32_array_fops
    with a file lifetime managing proxy.

    Make debugfs_create_u32_array() create its files in non-proxying operation
    mode by means of debugfs_create_file_unsafe().

    Signed-off-by: Nicolai Stange <nicstange@gmail.com>
    ---
    fs/debugfs/file.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    diff --git a/fs/debugfs/file.c b/fs/debugfs/file.c
    index 2e86d66..9c1c9a0 100644
    --- a/fs/debugfs/file.c
    +++ b/fs/debugfs/file.c
    @@ -992,7 +992,8 @@ struct dentry *debugfs_create_u32_array(const char *name, umode_t mode,
    data->array = array;
    data->elements = elements;

    - return debugfs_create_file(name, mode, parent, data, &u32_array_fops);
    + return debugfs_create_file_unsafe(name, mode, parent, data,
    + &u32_array_fops);
    }
    EXPORT_SYMBOL_GPL(debugfs_create_u32_array);

    --
    2.7.4
    \
     
     \ /
      Last update: 2016-03-22 15:01    [W:7.047 / U:0.080 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site