lkml.org 
[lkml]   [2016]   [Mar]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/9] x86: Add support for rd/wr fs/gs base
    On Mon, 21 Mar 2016, Andi Kleen wrote:
    > On Mon, Mar 21, 2016 at 03:08:46PM -0700, Andy Lutomirski wrote:
    > > On Mon, Mar 21, 2016 at 3:05 PM, Andi Kleen <andi@firstfloor.org> wrote:
    > > >> Please add a patch before this one that renames gs to gsbase. This is
    > > >> unreadable as is.
    > > >
    > > > I investigated this now, and it's not straight forward because on 32bit
    > > > ->gs is actually gsindex, not gsbase. So with a straight rename you
    > > > would end up with index in base on 32bit, which would be confusing.
    > > >
    > >
    > > I would take this inconsistency as a reason why this needs to be fixed
    > > before any further changes are made.
    >
    > The patchkit doesn't change anything for 32bit, so any inconsistency
    > in 32bit is completely orthogonal.
    >
    > I don't see how adding a bazillion unrelated changes makes this
    > patchkit any better.

    The general rule is that we do necessary cleanups before we change or add new
    functionality. That's nothing which can be negotiated. Period.

    Thanks,

    tglx


    \
     
     \ /
      Last update: 2016-03-22 10:21    [W:2.712 / U:0.076 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site