Messages in this thread | | | Subject | Re: [PATCH v3 0/2] irqchip/mbigen: fix the IO remap problem in mbigen driver. | From | "majun (F)" <> | Date | Tue, 22 Mar 2016 11:10:59 +0800 |
| |
在 2016/3/21 18:29, Thomas Gleixner 写道: > On Thu, 17 Mar 2016, MaJun wrote: >> This patch set is used to fix the problem of remap a set of registers >> repeatedly in current mbigen driver. >> >> irqchip/mbigen:Change the mbigen node definition in dt binding file >> irqchip/mbigen:Change the mbigen driver based on the new mbigen node definition > > These subject lines are still horrible as they tell nothing about the nature > of the change. I fixed them up along with the changelogs and applied them to > irq/urgent. Can you spot the difference?
Yes, after you changing, the subject and change log clearly show why we need to do this change. I have learned a lot from you :)
> > While at it. The config switch for this driver is horrible. It's just in the > middle of the device driver configs. Why is this configurable by the user at > all? It simply should be selected by arm64 or some subarch configuration > there. Please clean that up. > will do.
Thanks! MaJun
> Thanks, > > tglx > > . >
| |