lkml.org 
[lkml]   [2016]   [Mar]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 2/9] x86: Add support for rd/wr fs/gs base
    On Mon, Mar 21, 2016 at 3:05 PM, Andi Kleen <andi@firstfloor.org> wrote:
    >> Please add a patch before this one that renames gs to gsbase. This is
    >> unreadable as is.
    >
    > I investigated this now, and it's not straight forward because on 32bit
    > ->gs is actually gsindex, not gsbase. So with a straight rename you
    > would end up with index in base on 32bit, which would be confusing.
    >

    I would take this inconsistency as a reason why this needs to be fixed
    before any further changes are made.

    The variables should be called "gsbase" and "gsindex", full stop.
    It's not particularly risky -- we could even compare the generated
    code if we cared.

    --Andy

    \
     
     \ /
      Last update: 2016-03-21 23:21    [W:2.533 / U:0.192 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site