Messages in this thread | | | Date | Mon, 21 Mar 2016 17:40:30 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH] tools lib api: respect CROSS_COMPILE for the linker |
| |
Em Mon, Mar 21, 2016 at 09:08:52AM +0100, Jiri Olsa escreveu: > On Fri, Mar 18, 2016 at 02:38:52PM -0300, Arnaldo Carvalho de Melo wrote: > > Em Fri, Mar 18, 2016 at 12:16:23PM -0500, Josh Poimboeuf escreveu: > > > So 'allow-override' would probably be a good option.
> > Humm, my preference is to make tools/ look like the kernel, and the > > kernel doesn't use that allow-override thing, right? So perhaps add what > > is missing to make it look exactly like the kernel and then ditch this > > allow-override thing?
> Steven explained his reason for allow-override in the comment above it, > please make sure the new solution follows that
Sure, and I'm no make guru, but what puzzles me is why isn't this required in:
[acme@jouet linux]$ grep -w ^CC Makefile CC = $(CROSS_COMPILE)gcc [acme@jouet linux]$
> > What about having all this in a single place in tools/script/? > > maybe tools/script/Makefile.comp
But then we would have to include multiple files in each Makefile, perhaps it would be better to stash this in tools/scripts/Makefile.include, that way we wouldn't have to include any new file.
- Arnaldo
P.S.
While looking at the main kernel Makefile git history I found goodies we could use in tools/, like:
commit 84336466011c589b6af554f2f2f1fcfa1a5c1437 Author: Roland McGrath <roland@redhat.com> Date: Mon Dec 21 16:24:06 2009 -0800
kconfig CROSS_COMPILE option
-------------------------------------------------------------------------
And also by trying hard to mimic (preferrably use a exact copy) the kernel we can avoid suffering from subtle stuff like:
commit 2331d1a6cd3d6e580bc88b9a160066d9e1177fe1 Author: Sam Ravnborg <sam@ravnborg.org> Date: Sun Oct 11 23:22:58 2009 +0200
kbuild: revert "save ARCH & CROSS_COMPILE ..."
-------------------------------------------------------------------------
| |