lkml.org 
[lkml]   [2016]   [Mar]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] lan78xx: Protect runtime_auto check by #ifdef CONFIG_PM
From
Date
On Mon, 2016-03-21 at 10:57 -0400, Alan Stern wrote:

> One possible solution is to export a sysfs parameter to prevent
> statistics collection (or more generally, to change the interval at
> which it occurs).

Surely, not performing a task can hardly be beaten in terms of power
consumption. That is not meant to be flippant, but I think these
issues are orthogonal. The question of how much to do doesn't
solve the question of doing efficiently what we do.

> But checking the runtime_auto flag is probably not a great idea. Even
> if it isn't set, collecting statistics is likely to wait up a device
> that otherwise would have remained suspended.
>
> Perhaps the best solution is to collect the statistics only when the
> device is not suspended or is about to suspend.

If we know when the next activity will come, why not pass this
information down?

Regards
Oliver



\
 
 \ /
  Last update: 2016-03-21 19:21    [W:0.078 / U:0.112 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site