Messages in this thread Patch in this message | | | Subject | [PATCH 3/6] drivers/media/media-devnode: clear private_data before put_device() | From | Max Kellermann <> | Date | Mon, 21 Mar 2016 14:30:28 +0100 |
| |
Callbacks invoked from put_device() may free the struct media_devnode pointer, so any cleanup needs to be done before put_device().
Signed-off-by: Max Kellermann <max@duempel.org> --- drivers/media/media-devnode.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/media/media-devnode.c b/drivers/media/media-devnode.c index 4d7e8dd..e263816 100644 --- a/drivers/media/media-devnode.c +++ b/drivers/media/media-devnode.c @@ -196,10 +196,11 @@ static int media_release(struct inode *inode, struct file *filp) if (mdev->fops->release) mdev->fops->release(filp); + filp->private_data = NULL; + /* decrease the refcount unconditionally since the release() return value is ignored. */ put_device(&mdev->dev); - filp->private_data = NULL; return 0; }
| |