lkml.org 
[lkml]   [2016]   [Mar]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 01/71] arc: get rid of PAGE_CACHE_* and page_cache_{get,release} macros
On Sun, 20 Mar 2016, Linus Torvalds wrote:
> On Sun, Mar 20, 2016 at 12:34 PM, Kirill A. Shutemov
> <kirill.shutemov@linux.intel.com> wrote:
> >
> > Hm. Okay. Re-split this way would take some time. I'll post updated
> > patchset tomorrow.
>
> Oh, I was assuming this was automated with coccinelle or at least some
> simple shell scripting..
>
> Generally, for things like this, automation really is great.
>
> In fact, I like it when people attach the scripts to the commit
> message, further clarifying exactly what they did (even if the end
> result then often includes manual fixups for patterns that didn't
> _quite_ match, or where the automated script just generated ugly
> indentation or similar).

Fine by me to make these changes - once upon a time I had a better
grip than most of when and how to use PAGE_CACHE_blah; but have long
lost it, and agree with all those who find the imaginary distinction
now a drag.

Just a plea, which I expect you already intend, to apply these changes
either just before 4.6-rc1 or just before 4.7-rc1 (I think I'd opt for
4.6-rc1 myself), without any interim of days or months in linux-next,
where a period of divergence would be quite tiresome. Holding back
Kirill's 71/71 until the coast is clear just a little later.

Thanks,
Hugh

\
 
 \ /
  Last update: 2016-03-21 00:01    [W:0.583 / U:0.144 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site