lkml.org 
[lkml]   [2016]   [Mar]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 14/71] oprofile: get rid of PAGE_CACHE_* and page_cache_{get,release} macros
    Date
    PAGE_CACHE_{SIZE,SHIFT,MASK,ALIGN} macros were introduced *long* time ago
    with promise that one day it will be possible to implement page cache with
    bigger chunks than PAGE_SIZE.

    This promise never materialized. And unlikely will.

    We have many places where PAGE_CACHE_SIZE assumed to be equal to
    PAGE_SIZE. And it's constant source of confusion on whether PAGE_CACHE_*
    or PAGE_* constant should be used in a particular case, especially on the
    border between fs and mm.

    Global switching to PAGE_CACHE_SIZE != PAGE_SIZE would cause to much
    breakage to be doable.

    Let's stop pretending that pages in page cache are special. They are not.

    The changes are pretty straight-forward:

    - <foo> << (PAGE_CACHE_SHIFT - PAGE_SHIFT) -> <foo>;

    - PAGE_CACHE_{SIZE,SHIFT,MASK,ALIGN} -> PAGE_{SIZE,SHIFT,MASK,ALIGN};

    - page_cache_get() -> get_page();

    - page_cache_release() -> put_page();

    Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
    Cc: Robert Richter <rric@kernel.org>
    ---
    drivers/oprofile/oprofilefs.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/oprofile/oprofilefs.c b/drivers/oprofile/oprofilefs.c
    index b48ac6300c79..a0e5260bd006 100644
    --- a/drivers/oprofile/oprofilefs.c
    +++ b/drivers/oprofile/oprofilefs.c
    @@ -239,8 +239,8 @@ static int oprofilefs_fill_super(struct super_block *sb, void *data, int silent)
    {
    struct inode *root_inode;

    - sb->s_blocksize = PAGE_CACHE_SIZE;
    - sb->s_blocksize_bits = PAGE_CACHE_SHIFT;
    + sb->s_blocksize = PAGE_SIZE;
    + sb->s_blocksize_bits = PAGE_SHIFT;
    sb->s_magic = OPROFILEFS_MAGIC;
    sb->s_op = &s_ops;
    sb->s_time_gran = 1;
    --
    2.7.0
    \
     
     \ /
      Last update: 2016-03-20 20:41    [W:4.251 / U:0.204 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site