lkml.org 
[lkml]   [2016]   [Mar]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH] checkpatch.pl: add switch to turn off check for Change-Id
Date
Hi Joe,

Locally I will remove the patch and use the '--ignore' option.

Is there anything I need to do for upstream? (Sorry, I am new to submitting patches upstream)

-Dwane

-----Original Message-----
From: Joe Perches [mailto:joe@perches.com]
Sent: Tuesday, March 1, 2016 3:22 PM
To: Pottratz, Dwane <dwane.pottratz@intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>; LKML <linux-kernel@vger.kernel.org>; Andy Whitcroft <apw@canonical.com>
Subject: Re: [PATCH] checkpatch.pl: add switch to turn off check for Change-Id

On Tue, 2016-03-01 at 21:49 +0000, Pottratz, Dwane wrote:
> Good to know.  Thx.

Andrew picked this up, but it might be better to remove your patch and just use the --ignore option as --ignore is generic and your patch just duplicates the capability.


>
> -----Original Message-----
> From: Joe Perches [mailto:joe@perches.com]
> Sent: Tuesday, March 1, 2016 1:41 PM
> To: Pottratz, Dwane <dwane.pottratz@intel.com>; apw@canonical.com; li
> nux-kernel@vger.kernel.org; 'akpm@linux-foundation.org' <akpm@linux-f
> oundation.org>
> Subject: Re: [PATCH] checkpatch.pl: add switch to turn off check for
> Change-Id
>
> On Tue, 2016-03-01 at 18:37 +0000, Pottratz, Dwane wrote:
> >
> > A commit hook for the Gerrit code review servers inserts change
> > identifiers.  These identifiers are noise in the context of the
> > upstream kernel.  However, they are needed in most development
> > environments and the error needs to be ignored for static analysis
> > tools.
> btw: another way to do this is to use the --ignore <foo-list> option.
>
> $ ./scripts/checkpatch.pl --ignore gerrit_change_id <patch>
>

\
 
 \ /
  Last update: 2016-03-02 21:01    [W:0.045 / U:0.616 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site