Messages in this thread Patch in this message | | | Date | Wed, 02 Mar 2016 10:48:54 -0500 | From | Steven Rostedt <> | Subject | [PATCH RT 07/13] kernel: softirq: unlock with irqs on |
| |
3.12.54-rt74-rc1 stable review patch. If anyone has any objections, please let me know.
------------------
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
We unlock the lock while the interrupts are off. This isn't a problem now but will get because the migrate_disable() + enable are not symmetrical in regard to the status of interrupts.
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> Signed-off-by: Steven Rostedt <rostedt@goodmis.org> --- kernel/softirq.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/kernel/softirq.c b/kernel/softirq.c index cce9723c5a18..7c8e36bf9e2a 100644 --- a/kernel/softirq.c +++ b/kernel/softirq.c @@ -578,8 +578,10 @@ static void do_current_softirqs(int need_rcu_bh_qs) do_single_softirq(i, need_rcu_bh_qs); } softirq_clr_runner(i); - unlock_softirq(i); WARN_ON(current->softirq_nestcnt != 1); + local_irq_enable(); + unlock_softirq(i); + local_irq_disable(); } } -- 2.7.0
| |